X Tutup
Skip to content

gh-126618: fix repr(itertools.count(sys.maxsize))#127048

Merged
vstinner merged 1 commit intopython:mainfrom
skirpichev:fix-count-repr-126618
Dec 2, 2024
Merged

gh-126618: fix repr(itertools.count(sys.maxsize))#127048
vstinner merged 1 commit intopython:mainfrom
skirpichev:fix-count-repr-126618

Conversation

@skirpichev
Copy link
Member

@skirpichev skirpichev commented Nov 20, 2024 •
edited by bedevere-app bot
Loading

@skirpichev @picnixz
pythongh-126618: fix repr(itertools.count(sys.maxsize))
39e0c10 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this pull request Nov 20, 2024
Closed
@skirpichev skirpichev requested a review from picnixz November 20, 2024 06:22
@skirpichev skirpichev mentioned this pull request Nov 20, 2024
Closed
@skirpichev skirpichev marked this pull request as ready for review November 20, 2024 06:38
@skirpichev
Copy link
Member Author

skirpichev commented Nov 30, 2024

cc @vstinner (as this also include reversion of #126617)

picnixz
picnixz approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that you picked up my tests and NEWS entry so it should be fine.

@skirpichev
Copy link
Member Author

skirpichev commented Nov 30, 2024

Yes. And tests from #126617 aren't reverted, of course.

vstinner
vstinner approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 930ba0c into python:main Dec 2, 2024
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Dec 2, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 2, 2024

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2024
@skirpichev @picnixz @miss-islington
pythongh-126618: fix repr(itertools.count(sys.maxsize)) (pythonGH-127048
cbfa3fd 
)

(cherry picked from commit 930ba0c)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2024

GH-127508 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 2, 2024
@vstinner vstinner added the needs backport to 3.12 only security fixes label Dec 2, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 2, 2024

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Dec 2, 2024

Sorry, @skirpichev and @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 930ba0ce605eee9e3b992fa368b00a3f2b7dc4c1 3.12

@vstinner
Copy link
Member

vstinner commented Dec 2, 2024

@skirpichev @picnixz: Does the 3.12 branch have the bug? If yes, can you propose a backport @skirpichev?

@picnixz
Copy link
Member

picnixz commented Dec 2, 2024

I think so. The reason why I didn't put the 3.12 label before was because my branch used free-threaded special code. This fix is 3.12+ compatible (the fix that was reverted in this PR was backported up to 3.12).

@skirpichev skirpichev deleted the fix-count-repr-126618 branch December 2, 2024 13:26
@skirpichev
Copy link
Member Author

skirpichev commented Dec 2, 2024

I'm working on backport.

vstinner pushed a commit that referenced this pull request Dec 2, 2024
@miss-islington @skirpichev @picnixz
[3.13] gh-126618: fix repr(itertools.count(sys.maxsize)) (GH-127048) (#…
4bafce0 
…127508)

gh-126618: fix repr(itertools.count(sys.maxsize)) (GH-127048)
(cherry picked from commit 930ba0c)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2024

GH-127510 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 2, 2024
vstinner pushed a commit that referenced this pull request Dec 2, 2024
@skirpichev @picnixz
[3.12] gh-126618: fix repr(itertools.count(sys.maxsize)) (GH-127048) (#…
34fe4af 
…127510)

(cherry picked from commit 930ba0c)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@skirpichev @picnixz @srinivasreddy
pythongh-126618: fix repr(itertools.count(sys.maxsize)) (python#127048)
8b0bfb5 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@skirpichev @picnixz @ebonnal
pythongh-126618: fix repr(itertools.count(sys.maxsize)) (python#127048)
a15a80e 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@picnixz picnixz picnixz approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

+1 more reviewer

@Redeyder723 Redeyder723 Redeyder723 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skirpichev @vstinner @picnixz @Redeyder723
X Tutup