gh-126947: Typechecking for _pydatetime.timedelta.__new__ arguments#126949
Merged
sobolevn merged 5 commits intopython:mainfrom Nov 19, 2024
Merged
gh-126947: Typechecking for _pydatetime.timedelta.__new__ arguments#126949sobolevn merged 5 commits intopython:mainfrom
sobolevn merged 5 commits intopython:mainfrom
Conversation
…aised as in _datetime.timedelta
sobolevn
reviewed
Nov 18, 2024
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Now python implementation is in line with C implementation. Please, add a NEWS entry.
Contributor
Author
|
@sobolevn a NEWS entry has been added |
sobolevn
reviewed
Nov 18, 2024
Misc/NEWS.d/next/Library/2024-11-18-19-03-46.gh-issue-126947.NiDYUe.rst
Outdated
Show resolved
Hide resolved
…iDYUe.rst Co-authored-by: sobolevn <mail@sobolevn.me>
Misc/NEWS.d/next/Library/2024-11-18-19-03-46.gh-issue-126947.NiDYUe.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Member
|
Thanks! Let's wait for code-owners to review :) |
vstinner
approved these changes
Nov 19, 2024
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. The PR doesn't change the exception type, but provides a better error message.
ZeroIntensity
approved these changes
Nov 19, 2024
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
I might as well hop on the approval train :)
How do we feel about backporting?
Member
It's a bad idea to change error messages in a stable release, it can break tests. |
Eclips4
approved these changes
Nov 19, 2024
Member
|
Thanks everyone! |
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…ents (python#126949) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.