gh-126413: Add translation tests for getopt and optparse#126698
gh-126413: Add translation tests for getopt and optparse#126698serhiy-storchaka merged 5 commits intopython:mainfrom
getopt and optparse#126698Conversation
|
Not entirely sure if this needs a news entry, adding |
I think we can skip NEWS for test improvements. |
serhiy-storchaka
added
tests
|
Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @tomasr8 and @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @tomasr8 and @serhiy-storchaka, I could not cleanly backport this to |
|
Thanks for the review! I'll deal with the backports tomorrow :) |
…pythonGH-126698) (cherry picked from commit dff074d) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
|
GH-126755 is a backport of this pull request to the 3.13 branch. |
|
GH-126756 is a backport of this pull request to the 3.12 branch. |
3 participants
This is a followup from #124295
Given that the tests for
getoptandoptparseare essentially the same as the ones forargparse, I extracted the snapshot file generation and comparison intotest.support.i18n_helperin order not to repeat the code three times. The majority of the diff is just moving that code fromtest_argpasetotest.support.i18n_helper.Just like for
argparse, the snapshots are generated inLib/test/translationdataand are updated the same way using--snapshot-update.