Conversation
|
The gc crasher seems to hang and occasionally segfault on the FT build, I'll skip it for now and open a separate issue about it. |
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
One confusing comment then fixing or removing. Otherwise LGTM.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again 🙂 |
|
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
AA-Turner
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @AA-Turner for commit d5be44b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F126360%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
4 participants
mutation_inside_cyclegc.pyandtrace_at_recursion_limit.pydo not crash anymore.This PR moves them out of crashers and into unit tests to ensure they do not start crashing again.
Lib/test/crashers#121921