gh-126357: Remove gettext import guards#126358
Conversation
sobolevn
left a comment
There was a problem hiding this comment.
Can this affect other implementations like PyPy?
|
I don't know enough about PyPy to be able to answer that :/ Do you know how I could verify that? |
|
You can take a look at the source code (https://github.com/pypy/pypy prefered way) or ping one of PyPy maintainers :) I suspect that it won't, but just to be sure. |
|
Ok so I applied this patch to the vendored stdlib in PyPy and built pypy3.11 without any issues. Importing these modules at runtime does not cause any issues either so I think it should be fine. The 4 buildbot failures also seem unrelated to this change. |
sobolevn
left a comment
There was a problem hiding this comment.
LGTM then! Thanks for checking!
|
I think that if there are some bootstrapping issues with the |
gettextingetoptandoptparse#126357