gh-126209: Fix inconsistency of skip_file_prefixes in warnings.warn's C and Python implementations#126329
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
zsaladin
force-pushed
the
fix/warnings
branch
from
a2caf9a to
3bd3350
Compare
picnixz
changed the title
skip_file_prefixes in warnings.warn's C and Python implementations
|
Some tips: could you avoid force-pushing your commits in the future please? It makes reviewing harder (see https://devguide.python.org/getting-started/pull-request-lifecycle). Thanks! |
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
Maybe we could add a test for skip_file_prefixes?
Misc/NEWS.d/next/Core_and_Builtins/2024-11-02-18-01-31.gh-issue-126209.2ZIhrS.rst
Outdated
Show resolved
Hide resolved
…e-126209.2ZIhrS.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
My apology. I will avoid force-pushing as you said. |
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Misc/NEWS.d/next/Core_and_Builtins/2024-11-02-18-01-31.gh-issue-126209.2ZIhrS.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
…gs.warn`'s C and Python implementations (pythonGH-126329) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
…gs.warn`'s C and Python implementations (pythonGH-126329) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
5 participants
__file__. #126209I think setting the argument
end=-1the functiontailmatchmay cause undefined behavior. Most oftailmatchfunctions I've seen are used withend=PY_SSIZE_T_MAXand never seenend=-1except for this case.hopefully I will help