X Tutup
Skip to content

GH-126205: Fix conversion of UNC paths to file URIs#126208

Merged
barneygale merged 2 commits intopython:mainfrom
barneygale:gh-126205
Oct 30, 2024
Merged

GH-126205: Fix conversion of UNC paths to file URIs#126208
barneygale merged 2 commits intopython:mainfrom
barneygale:gh-126205

Conversation

@barneygale
Copy link
Contributor

@barneygale barneygale commented Oct 30, 2024 •
edited
Loading

File URIs for Windows UNC paths should begin with two slashes, not four - see issue.

@barneygale
pythonGH-126205: Fix conversion of UNC paths to file URIs
76025e0 
File URIs for Windows UNC paths should begin with two slashes, not four.
@barneygale barneygale added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 30, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 30, 2024
Closed
@barneygale barneygale marked this pull request as ready for review October 30, 2024 21:02
@barneygale barneygale requested a review from zooba October 30, 2024 21:02
zooba
zooba approved these changes Oct 30, 2024
View reviewed changes
@barneygale
Copy link
Contributor Author

barneygale commented Oct 30, 2024

Thanks very much Steve!

@barneygale barneygale merged commit 951cb2c into python:main Oct 30, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 30, 2024

Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@barneygale barneygale added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 31, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 31, 2024

Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 31, 2024

Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2024
@barneygale @miss-islington
pythonGH-126205: Fix conversion of UNC paths to file URIs (pythonGH-1…
63e1151 
…26208)

File URIs for Windows UNC paths should begin with two slashes, not four.
(cherry picked from commit 951cb2c)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2024
@barneygale @miss-islington
pythonGH-126205: Fix conversion of UNC paths to file URIs (pythonGH-1…
1e81eb8 
…26208)

File URIs for Windows UNC paths should begin with two slashes, not four.
(cherry picked from commit 951cb2c)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 31, 2024

GH-126248 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 31, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 31, 2024

GH-126249 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 31, 2024
barneygale added a commit that referenced this pull request Oct 31, 2024
@miss-islington @barneygale
[3.13] GH-126205: Fix conversion of UNC paths to file URIs (GH-126208) (
588da2e 
#126249)

GH-126205: Fix conversion of UNC paths to file URIs (GH-126208)

File URIs for Windows UNC paths should begin with two slashes, not four.
(cherry picked from commit 951cb2c)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
barneygale added a commit that referenced this pull request Oct 31, 2024
@miss-islington @barneygale
[3.12] GH-126205: Fix conversion of UNC paths to file URIs (GH-126208) (
78f307f 
#126248)

GH-126205: Fix conversion of UNC paths to file URIs (GH-126208)

File URIs for Windows UNC paths should begin with two slashes, not four.
(cherry picked from commit 951cb2c)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
@barneygale barneygale mentioned this pull request Nov 8, 2024
Merged
@ichard26 ichard26 mentioned this pull request Dec 7, 2024
Closed
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@barneygale @picnixz
pythonGH-126205: Fix conversion of UNC paths to file URIs (python#126208
68c151c 
)

File URIs for Windows UNC paths should begin with two slashes, not four.
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@barneygale @ebonnal
pythonGH-126205: Fix conversion of UNC paths to file URIs (python#126208
132ce80 
)

File URIs for Windows UNC paths should begin with two slashes, not four.
@barneygale barneygale mentioned this pull request Jul 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@barneygale @zooba
X Tutup