Android: update tests for newly-available functions affected by SELinux#126015
Merged
freakboy3742 merged 1 commit intopython:mainfrom Oct 27, 2024
Merged
Android: update tests for newly-available functions affected by SELinux#126015freakboy3742 merged 1 commit intopython:mainfrom
freakboy3742 merged 1 commit intopython:mainfrom
Conversation
Member
Author
|
!buildbot android |
freakboy3742
approved these changes
Oct 27, 2024
Contributor
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
👍
Looks good, and the logic around skipping the tests rather than reconfiguring makes sense to me.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…ux (python#126015) Skip tests on Android that involve use of SELinux-protected methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#125946 increased the minimum Android API level to 24. This has caused some additional libc APIs to become available at compile time, which always return PermissionError at runtime.
I considered editing the configure script so that these functions are ignored at compile time, but experience from Chaquopy has shown that there's a lot of code out there which can handle a PermissionError (or its superclass OSError) when a function fails, but not the AttributeError which would happen if the function didn't exist at all. So I've skipped the affected tests instead.