GH-125789: fix fut._callbacks to always return a copy of callbacks#125922
Merged
kumaraditya303 merged 2 commits intopython:mainfrom Oct 25, 2024
Merged
GH-125789: fix fut._callbacks to always return a copy of callbacks#125922kumaraditya303 merged 2 commits intopython:mainfrom
fut._callbacks to always return a copy of callbacks#125922kumaraditya303 merged 2 commits intopython:mainfrom
Conversation
kumaraditya303
commented
Oct 24, 2024
Misc/NEWS.d/next/Library/2024-10-24-14-08-10.gh-issue-125789.eaiAMw.rst
Outdated
Show resolved
Hide resolved
kumaraditya303
force-pushed
the
callbacks
branch
from
122f789 to
63f1957
Compare
kumaraditya303
requested review from
1st1,
asvetlov,
gvanrossum and
willingc
as code owners
Contributor
Author
== Tests result: SUCCESS ==
1 test skipped:
test_asyncio.test_unix_events
30 tests OK.
Total duration: 6 min 8 sec
Total tests: run=2,242 skipped=74
Total test files: run=31/31 skipped=1
Result: SUCCESS
Refleak tested |
kumaraditya303
added
topic-asyncio
3.12
picnixz
reviewed
Oct 25, 2024
Member
There was a problem hiding this comment.
I would add a test for that (e.g., one of the test that Nico wrote with the evil classes) to see that the interpreter does not crash anymore.
EDIT: My previous comment was wrong. We can still change the length by just adding new callbacks but we cannot change the type of the items.
Contributor
Author
I think it is more appropriate to add that to your PR which fixes the UAF issues. |
|
Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @kumaraditya303, I could not cleanly backport this to |
|
Sorry, @kumaraditya303, I could not cleanly backport this to |
|
GH-125976 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
added a commit
to kumaraditya303/cpython
that referenced
this pull request
Oct 25, 2024
…backs (python#125922) Fix `asyncio.Future._callbacks` to always return a copy of the internal list of callbacks to avoid mutation from user code affecting the internal state. (cherry picked from commit cae853e)
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 25, 2024
…of callbacks (pythonGH-125922) (pythonGH-125976) pythonGH-125789: fix `fut._callbacks` to always return a copy of callbacks (pythonGH-125922) Fix `asyncio.Future._callbacks` to always return a copy of the internal list of callbacks to avoid mutation from user code affecting the internal state. (cherry picked from commit f54e1a2) Co-authored-by: Kumar Aditya <kumaraditya@python.org> (cherry picked from commit cae853e)
kumaraditya303
added a commit
that referenced
this pull request
Oct 25, 2024
…lbacks (GH-125922) (#125977) GH-125789: fix `fut._callbacks` to always return a copy of callbacks (GH-125922) Fix `asyncio.Future._callbacks` to always return a copy of the internal list of callbacks to avoid mutation from user code affecting the internal state. Co-authored-by: Kumar Aditya <kumaraditya@python.org> (cherry picked from commit cae853e)
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…backs (python#125922) Fix `asyncio.Future._callbacks` to always return a copy of the internal list of callbacks to avoid mutation from user code affecting the internal state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.