gh-124928: Emscripten node support: Clean up old node <= 16 flags#124929
gh-124928: Emscripten node support: Clean up old node <= 16 flags#124929freakboy3742 merged 4 commits intopython:mainfrom
Conversation
These flags are only needed for node <= 16. Node 16 has been end of life since October of 2023.
corona10
left a comment
corona10
left a comment
There was a problem hiding this comment.
Hmm, can we add some assertion to check that user is using Node > 16?
|
Yeah that makes sense I will do that. |
|
Okay now it prints the following complaint to standard error and exits with code 1 on old node versions. |
corona10
left a comment
corona10
left a comment
There was a problem hiding this comment.
Please also add NEWS.d that now CPython requires Node >= 18 for Emscripten build :)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
brettcannon
requested review from
freakboy3742
and removed request for
brettcannon
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
Code changes look good; as noted elsewhere, a news entry is definitely required (the devguide has details on how to generate one).
I'll also hold off merging until python/steering-council#256 is resolved.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
hoodmane
force-pushed
the
emscripten-node-flag-cleanup
branch
from
c3360eb to
83d5082
Compare
hoodmane
force-pushed
the
emscripten-node-flag-cleanup
branch
from
83d5082 to
96e9e40
Compare
|
@freakboy3742 can we merge now that python/steering-council#256 is approved? |
…gs (python#124929) Clean up configure flags for old node versions These flags are only needed for node <= 16. Node 16 has been end of life since October of 2023.
…gs (python#124929) Clean up configure flags for old node versions These flags are only needed for node <= 16. Node 16 has been end of life since October of 2023.
4 participants
These flags are only needed for node <= 16. Node 16 has been end of life since
October of 2023.