gh-124445: Allow specializing generic ParamSpec aliases#124512
Merged
JelleZijlstra merged 18 commits intopython:mainfrom Mar 3, 2025
Merged
gh-124445: Allow specializing generic ParamSpec aliases#124512JelleZijlstra merged 18 commits intopython:mainfrom
JelleZijlstra merged 18 commits intopython:mainfrom
Conversation
tomasr8
commented
Sep 25, 2024
Member
Author
|
Just trying to debug this weird error now: Unfortunately seems to only happen when running the tests, not when I run the test case as a script :/ |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
tomasr8
commented
Sep 26, 2024
Member
Author
|
Ready for another round :) |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Misc/NEWS.d/next/Core_and_Builtins/2024-09-25-13-45-01.gh-issue-124445.zfsD7q.rst
Outdated
Show resolved
Hide resolved
Member
Author
|
ping @JelleZijlstra in case you forgot about this 🙂 |
JelleZijlstra
approved these changes
Mar 3, 2025
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good but I'm going to run refleak tests locally to make sure I'm not missing something.
|
Member
Author
|
Buildbot failure seems unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I more or less understood how this is supposed to work, but please let me know if I missed something :)
Also, if you think I should add more tests.