X Tutup
Skip to content

gh-112328: Make EnumDict usable on its own and document it#123669

Merged
ethanfurman merged 13 commits intopython:mainfrom
encukou:enumdict-docs-112328
Dec 20, 2024
Merged

gh-112328: Make EnumDict usable on its own and document it#123669
ethanfurman merged 13 commits intopython:mainfrom
encukou:enumdict-docs-112328

Conversation

@encukou
Copy link
Member

@encukou encukou commented Sep 4, 2024 •
edited by github-actions bot
Loading

This is a continuation of @u2rafi's PR #121720, with @AA-Turner's review comments addressed.

@ethanfurman, I noticed EnumDict relies on a private attribute, so I made that attribute optional, and added tests.
Is this what you intended when making EnumDict public? Or was it more for typing and isinstance rather than using it in custom __prepare__?

📚 Documentation preview 📚: https://cpython-previews--123669.org.readthedocs.build/

@bedevere-app bedevere-app bot mentioned this pull request Sep 4, 2024
Closed
@encukou encukou mentioned this pull request Sep 4, 2024
Merged
@encukou
Copy link
Member Author

encukou commented Sep 16, 2024

@ethanfurman, could you clarify how EnumDict should be used?

@encukou
Copy link
Member Author

encukou commented Dec 2, 2024

@ethanfurman, could you clarify how EnumDict is meant to be used?

@ethanfurman ethanfurman merged commit 2a66dd3 into python:main Dec 20, 2024
@ethanfurman ethanfurman added 3.13 bugs and security fixes 3.14 bugs and security fixes needs backport to 3.13 bugs and security fixes labels Dec 20, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 20, 2024

Thanks @encukou for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Dec 20, 2024

Sorry, @encukou and @ethanfurman, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2a66dd33dfc0b845042da9bb54aaa4e890733f54 3.13

@bedevere-bot
Copy link

bedevere-bot commented Dec 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO 3.x has failed when building commit 2a66dd3.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/338/builds/7721) and take a look at the build logs.
  4. Check if the failure is related to this commit (2a66dd3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/338/builds/7721

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 30, in task
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 47, in run
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

@bedevere-app
Copy link

bedevere-app bot commented Dec 20, 2024

GH-128142 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 20, 2024
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Dec 23, 2024
@encukou @u2rafi
@webknjaz @ethanfurman @srinivasreddy
pythongh-112328: Make EnumDict usable on its own and document it (pyt…
8d4f62d 
…honGH-123669)

Co-authored-by: Rafi <rafi.promit@gmail.com>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman added a commit that referenced this pull request Dec 24, 2024
@ethanfurman @encukou
[3.13] gh-112328: Make EnumDict usable on its own and document it (GH…
875e49f 
…-123669) (GH-128142)

Co-authored-by: Petr Viktorin <pviktori@redhat.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@encukou @u2rafi
@webknjaz @ethanfurman @srinivasreddy
pythongh-112328: Make EnumDict usable on its own and document it (pyt…
ff26364 
…honGH-123669)

Co-authored-by: Rafi <rafi.promit@gmail.com>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

@ethanfurman ethanfurman

Labels

3.13 bugs and security fixes 3.14 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@encukou @bedevere-bot @ethanfurman @u2rafi
X Tutup