gh-107954, PEP 741: Add PyConfig_Get() function#123472
Merged
vstinner merged 18 commits intopython:mainfrom Sep 2, 2024
Merged
gh-107954, PEP 741: Add PyConfig_Get() function#123472vstinner merged 18 commits intopython:mainfrom
vstinner merged 18 commits intopython:mainfrom
Conversation
Add PyConfig_Get(), PyConfig_GetInt(), PyConfig_Set() and PyConfig_Names() functions to get and set the current runtime Python configuration. _PyConfig_AsDict() now converts PyConfig.xoptions as a dictionary.
vstinner
requested review from
a team,
ericsnowcurrently and
erlend-aasland
as code owners
Member
Author
|
(Previous version of the PR, before PEP 741 was accepted: #112609.) |
Member
Author
|
cc @zooba |
picnixz
reviewed
Aug 30, 2024
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
I don't have much to say except my usual style nitpicks.
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Member
Author
|
@picnixz: About your suggested changes to replace |
Member
Author
|
@picnixz: I addressed most of your reviews. |
Member
Sound good to me. Consistency in this case is better so I'm fine. And PEP 7 indeed doesn't say anything on this matter (it just says that the function name must be on its own line I think).
Thank you! |
Update also PyConfig in _PySys_SetIntMaxStrDigits().
Add _PyWideStringList_AsTuple() function.
|
|
Member
|
@vstinner Seems this PR broke the Linux perf profiler buildbots (and have been broken since) |
Member
Author
|
@pablogsal do you have some details? |
Member
|
No other than the buildbot logs |
Member
|
I can try to look into this once I am back from the core dev sprint since here I don't have a laptop with new enough perf |
Member
|
I can confirm that the previous commit builds correctly |
Member
|
Found the problem: #124636 |
Contributor
|
Yes, it fixes the issue I raised Thanks! |
Contributor
|
But also the real question is: why wasn't this picked up by the GH runners and rely on buildbot builds? |
Member
Because running the minimum Perf in GH runners is close to impossible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PyConfig_Get(), PyConfig_GetInt(), PyConfig_Set() and PyConfig_Names() functions to get and set the current runtime Python configuration.
_PyConfig_AsDict() now converts PyConfig.xoptions as a dictionary.
📚 Documentation preview 📚: https://cpython-previews--123472.org.readthedocs.build/