X Tutup
Skip to content

gh-123446: Fix empty function names in TypeErrors in _csv module (follow-up to gh-123461)#123462

Merged
sobolevn merged 1 commit intopython:mainfrom
sobolevn:issue-123446-csv2
Aug 29, 2024
Merged

gh-123446: Fix empty function names in TypeErrors in _csv module (follow-up to gh-123461)#123462
sobolevn merged 1 commit intopython:mainfrom
sobolevn:issue-123446-csv2

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 29, 2024 •
edited by bedevere-app bot
Loading

After:

>>> import csv
>>> csv.reader()
Traceback (most recent call last):
  File "<python-input-3>", line 1, in <module>
    csv.reader()
    ~~~~~~~~~~^^
TypeError: reader expected at least 1 argument, got 0
>>> csv.writer()
Traceback (most recent call last):
  File "<python-input-4>", line 1, in <module>
    csv.writer()
    ~~~~~~~~~~^^
TypeError: writer expected at least 1 argument, got 0
>>> csv.register_dialect()
Traceback (most recent call last):
  File "<python-input-5>", line 1, in <module>
    csv.register_dialect()
    ~~~~~~~~~~~~~~~~~~~~^^
TypeError: register_dialect expected at least 1 argument, got 0

Follow up to #123461

@bedevere-app bedevere-app bot mentioned this pull request Aug 29, 2024
Closed
@sobolevn sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes skip news labels Aug 29, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

BTW, @sobolevn is a core developer and can merge his PRs.

@hauntsaninja
Copy link
Contributor

hauntsaninja commented Aug 29, 2024

Oh right, for a while sobolevn didn't want to be one :-) Sorry for the early merge!

@sobolevn
Copy link
Member Author

sobolevn commented Aug 29, 2024

@hauntsaninja no worries, no harm done :)
Thanks everyone! 👏

@sobolevn sobolevn merged commit 58ce131 into python:main Aug 29, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Aug 29, 2024

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Aug 29, 2024

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 58ce131037ecb34d506a613f21993cde2056f628 3.13

@miss-islington-app
Copy link

miss-islington-app bot commented Aug 29, 2024

Sorry, @sobolevn, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 58ce131037ecb34d506a613f21993cde2056f628 3.12

sobolevn added a commit to sobolevn/cpython that referenced this pull request Aug 29, 2024
@sobolevn
[3.12] pythongh-123446: Fix empty function names in TypeErrors in `…
87052e5 
…_csv` module (pythonGH-123462)

(cherry picked from commit 58ce131)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Aug 29, 2024

GH-123466 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Aug 29, 2024
@picnixz picnixz changed the title gh-123446: Fix empty function names in TypeErrors in _csv module gh-123446: Fix empty function names in TypeErrors in _csv module (follow-up to gh-123461) Aug 29, 2024
@picnixz
Copy link
Member

picnixz commented Aug 29, 2024

I just changed the title otherwise I thought there were twice the same PR on the tracker :')

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Aug 29, 2024

I am not sure that it is worth to backport this change. This is just a minor enhancement in error messages.

@sobolevn
Copy link
Member Author

sobolevn commented Aug 29, 2024

I am not sure that it is worth to backport this change. This is just a minor enhancement in error messages.

Ok, I can close them 👍

@hauntsaninja hauntsaninja removed the needs backport to 3.13 bugs and security fixes label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@sobolevn sobolevn

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @hauntsaninja @picnixz @serhiy-storchaka
X Tutup