gh-123446: Fix empty function names in TypeErrors in _csv module#123461
Merged
hauntsaninja merged 1 commit intopython:mainfrom Aug 29, 2024
Merged
gh-123446: Fix empty function names in TypeErrors in _csv module#123461hauntsaninja merged 1 commit intopython:mainfrom
TypeErrors in _csv module#123461hauntsaninja merged 1 commit intopython:mainfrom
Conversation
hauntsaninja
approved these changes
Aug 29, 2024
| } | ||
|
|
||
| if (!PyArg_UnpackTuple(args, "", 1, 2, &iterator, &dialect)) { | ||
| if (!PyArg_UnpackTuple(args, "_csv.reader", 1, 2, &iterator, &dialect)) { |
Member
There was a problem hiding this comment.
This unnecessary exposes the implementation detail (the private module name).
>>> import csv
>>> csv.reader
<built-in function reader>
>>> csv.reader()
Traceback (most recent call last):
File "<python-input-2>", line 1, in <module>
csv.reader()
~~~~~~~~~~^^
TypeError: _csv.reader expected at least 1 argument, got 0Compare with:
>>> import os
>>> os.mkdir()
Traceback (most recent call last):
File "<python-input-1>", line 1, in <module>
os.mkdir()
~~~~~~~~^^
TypeError: mkdir() missing required argument 'path' (pos 1)
Member
Author
There was a problem hiding this comment.
Yes, this was my open question. I will remove the module name.
@hauntsaninja sorry, I should have made this more clear :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After:
Questions:
_csv.orcsv.? Technically the module is_csv, but users can see this when these names are re-exported incsvmodule. I prefer to show the real name.CC @hauntsaninja, because you have several recent commits to this module.
CC @serhiy-storchaka, because you commented on the issue.
PyArg_UnpackTupleis used withname=""#123446