X Tutup
Skip to content

gh-123340: Show string value of IS_OP oparg in dis#123348

Merged
sobolevn merged 2 commits intopython:mainfrom
sobolevn:issue-123340
Aug 26, 2024
Merged

gh-123340: Show string value of IS_OP oparg in dis#123348
sobolevn merged 2 commits intopython:mainfrom
sobolevn:issue-123340

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 26, 2024 •
edited by bedevere-app bot
Loading

After:

» echo 'a is not b' | ./python.exe -m dis
  0           RESUME                   0

  1           LOAD_NAME                0 (a)
              LOAD_NAME                1 (b)
              IS_OP                    1 (is not)
              POP_TOP
              RETURN_CONST             0 (None)

and

» echo 'a is b' | ./python.exe -m dis    
  0           RESUME                   0

  1           LOAD_NAME                0 (a)
              LOAD_NAME                1 (b)
              IS_OP                    0 (is)
              POP_TOP
              RETURN_CONST             0 (None)

@bedevere-app bedevere-app bot mentioned this pull request Aug 26, 2024
Closed
picnixz
picnixz approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick.

@sobolevn sobolevn merged commit 1eed0f9 into python:main Aug 26, 2024
@sobolevn
Copy link
Member Author

sobolevn commented Aug 26, 2024

Thank you both for the reviews!

@sobolevn sobolevn mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@picnixz picnixz picnixz approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @JelleZijlstra @picnixz
X Tutup