A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I have made the requested changes; please review again

Thanks for making the requested changes!

@barneygale: please review the changes made to this pull request.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Thanks for the nits! I have made the requested changes; please review again

Thanks for making the requested changes!

@barneygale: please review the changes made to this pull request.

There we go! @barneygale, lint is fixed.

Thanks for this :)

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.x has failed when building commit 9dbd123.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/4) and take a look at the build logs.
4. Check if the failure is related to this commit (9dbd123) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/4

Failed tests:

• test_android

Failed subtests:

• test_rate_limit - test.test_android.TestAndroidOutput.test_rate_limit

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_android.py", line 424, in test_rate_limit
    self.assertAlmostEqual(
    ~~~~~~~~~~~~~~~~~~~~~~^
        write_bucketful(), MAX_KB_PER_SECOND,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        delta=MAX_KB_PER_SECOND * 0.1
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 155.1962939117436 != 100 within 10.0 delta (55.196293911743595 difference)

I doubt that's related.

Looks like that test isn't as reliable as I thought. To avoid further spam, I'll shut down the Android buildbot until we get that sorted.