gh-122888: Fix crash on certain calls to str()#122889
Merged
JelleZijlstra merged 4 commits intopython:mainfrom Aug 12, 2024
Merged
gh-122888: Fix crash on certain calls to str()#122889JelleZijlstra merged 4 commits intopython:mainfrom
JelleZijlstra merged 4 commits intopython:mainfrom
Conversation
ZeroIntensity
approved these changes
Aug 10, 2024
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
Confimed to fix #122888 :)
Does this need to be backported to 3.13?
Eclips4
approved these changes
Aug 11, 2024
serhiy-storchaka
approved these changes
Aug 11, 2024
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM, but I think that the tests could be unified with the existing tests.
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Thank you for unifying the tests @JelleZijlstra.
You can also remove the self.assertRaises(TypeError, str, 42, 42, 42) line from test_constructor.
serhiy-storchaka
approved these changes
Aug 12, 2024
|
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 12, 2024
Fixes pythonGH-122888 (cherry picked from commit 53ebb62) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
GH-122947 is a backport of this pull request to the 3.13 branch. |
JelleZijlstra
added a commit
that referenced
this pull request
Aug 12, 2024
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122888
str()crashes the interpreter #122888