X Tutup
Skip to content

gh-122792: Make IPv4-mapped IPv6 address properties consistent with IPv4#122793

Merged
gpshead merged 2 commits intopython:mainfrom
sethmlarson:ipv4-mapped-props
Sep 7, 2024
Merged

gh-122792: Make IPv4-mapped IPv6 address properties consistent with IPv4#122793
gpshead merged 2 commits intopython:mainfrom
sethmlarson:ipv4-mapped-props

Conversation

@sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Aug 7, 2024 •
edited by bedevere-app bot
Loading

This pull request makes all properties for IPv4-mapped IPv6 addresses use the mapped IPv4 address to determine the values.

@sethmlarson sethmlarson added type-security A security issue stdlib Standard Library Python modules in the Lib/ directory labels Aug 7, 2024
@bedevere-app bedevere-app bot mentioned this pull request Aug 7, 2024
Closed
@sethmlarson sethmlarson requested a review from gpshead August 7, 2024 15:46
@sethmlarson
Copy link
Contributor Author

sethmlarson commented Aug 7, 2024

Requesting @gpshead as a reviewer since you reviewed the previous PR that did the same for is_private.

@gpshead gpshead merged commit 76a1c5d into python:main Sep 7, 2024
@gpshead gpshead added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 7, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 7, 2024

Thanks @sethmlarson for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Sep 7, 2024

Thanks @sethmlarson for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2024
@sethmlarson @miss-islington
pythongh-122792: Make IPv4-mapped IPv6 address properties consistent …
83645d9 
…with IPv4 (pythonGH-122793)

Make IPv4-mapped IPv6 address properties consistent with IPv4.
(cherry picked from commit 76a1c5d)

Co-authored-by: Seth Michael Larson <seth@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Sep 7, 2024

GH-123814 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2024
@sethmlarson @miss-islington
pythongh-122792: Make IPv4-mapped IPv6 address properties consistent …
16774f4 
…with IPv4 (pythonGH-122793)

Make IPv4-mapped IPv6 address properties consistent with IPv4.
(cherry picked from commit 76a1c5d)

Co-authored-by: Seth Michael Larson <seth@python.org>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 7, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 7, 2024

GH-123815 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 7, 2024
@gpshead gpshead added the needs backport to 3.11 only security fixes label Sep 7, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 7, 2024

Thanks @sethmlarson for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@gpshead gpshead added the needs backport to 3.10 only security fixes label Sep 7, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 7, 2024

Thanks @sethmlarson for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Sep 7, 2024

Thanks @sethmlarson for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2024
@sethmlarson @miss-islington
pythongh-122792: Make IPv4-mapped IPv6 address properties consistent …
abecf3f 
…with IPv4 (pythonGH-122793)

Make IPv4-mapped IPv6 address properties consistent with IPv4.
(cherry picked from commit 76a1c5d)

Co-authored-by: Seth Michael Larson <seth@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Sep 7, 2024

GH-123818 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 7, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2024
@sethmlarson @miss-islington
pythongh-122792: Make IPv4-mapped IPv6 address properties consistent …
0360df1 
…with IPv4 (pythonGH-122793)

Make IPv4-mapped IPv6 address properties consistent with IPv4.
(cherry picked from commit 76a1c5d)

Co-authored-by: Seth Michael Larson <seth@python.org>
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 7, 2024

Sorry, @sethmlarson and @gpshead, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 76a1c5d18312712baed4699fe7333abb050ec9b7 3.9

@bedevere-app
Copy link

bedevere-app bot commented Sep 7, 2024

GH-123819 is a backport of this pull request to the 3.10 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.10 only security fixes label Sep 7, 2024
gpshead pushed a commit that referenced this pull request Sep 7, 2024
@miss-islington @sethmlarson
[3.12] gh-122792: Make IPv4-mapped IPv6 address properties consistent…
e0c69e4 
… with IPv4 (GH-122793) (GH-123814)

gh-122792: Make IPv4-mapped IPv6 address properties consistent with IPv4 (GH-122793)

Make IPv4-mapped IPv6 address properties consistent with IPv4.
(cherry picked from commit 76a1c5d)

Co-authored-by: Seth Michael Larson <seth@python.org>
@sethmlarson sethmlarson deleted the ipv4-mapped-props branch September 9, 2024 12:57
@picnixz
Copy link
Member

picnixz commented Sep 9, 2024 •
edited
Loading

@sethmlarson The 3.9 backport failed so you'll need to create one manually. (My cherry-picker is dissident...)

ambv pushed a commit that referenced this pull request Dec 3, 2024
@miss-islington @sethmlarson
[3.13] gh-122792: Make IPv4-mapped IPv6 address properties consistent…
a63e06d 
… with IPv4 (GH-122793) (GH-123815)

Make IPv4-mapped IPv6 address properties consistent with IPv4.
(cherry picked from commit 76a1c5d)

Co-authored-by: Seth Michael Larson <seth@python.org>
ambv added a commit that referenced this pull request Dec 3, 2024
@miss-islington @sethmlarson @ambv
[3.11] gh-122792: Make IPv4-mapped IPv6 address properties consistent…
66a01b0 
… with IPv4 (GH-122793) (GH-123818)

Make IPv4-mapped IPv6 address properties consistent with IPv4.
(cherry picked from commit 76a1c5d)

Co-authored-by: Seth Michael Larson <seth@python.org>

---------

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Dec 3, 2024
@miss-islington @sethmlarson @ambv
[3.10] gh-122792: Make IPv4-mapped IPv6 address properties consistent…
b58da40 
… with IPv4 (GH-122793) (GH-123819)

Make IPv4-mapped IPv6 address properties consistent with IPv4.
(cherry picked from commit 76a1c5d)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit to ambv/cpython that referenced this pull request Dec 3, 2024
@miss-islington @sethmlarson @ambv
[3.9] [3.10] pythongh-122792: Make IPv4-mapped IPv6 address propertie…
8835d72 
…s consistent with IPv4 (pythonGH-122793) (pythonGH-123819)

Make IPv4-mapped IPv6 address properties consistent with IPv4.
(cherry picked from commit 76a1c5d)

(cherry picked from commit b58da40)

Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Dec 3, 2024
@ambv @sethmlarson
[3.9] gh-122792: Make IPv4-mapped IPv6 address properties consistent …
a897b4a 
…with IPv4 (GH-122793) (GH-123819) (GH-127571)

Make IPv4-mapped IPv6 address properties consistent with IPv4.
(cherry picked from commit 76a1c5d)
(cherry picked from commit b58da40)

Co-authored-by: Seth Michael Larson <seth@python.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request Apr 9, 2025
@ambv @sethmlarson @mgorny
[3.9] pythongh-122792: Make IPv4-mapped IPv6 address properties consi…
66af90f 
…stent with IPv4 (pythonGH-122793) (pythonGH-123819) (pythonGH-127571)

Make IPv4-mapped IPv6 address properties consistent with IPv4.
(cherry picked from commit 76a1c5d)
(cherry picked from commit b58da40)

Co-authored-by: Seth Michael Larson <seth@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@gpshead gpshead gpshead approved these changes

+1 more reviewer

@tiziruz tiziruz tiziruz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gpshead gpshead

Labels

stdlib Standard Library Python modules in the Lib/ directory type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sethmlarson @picnixz @gpshead @ZeroIntensity @tiziruz @terryjreedy
X Tutup