gh-109252: Remove leading whitespace email#122617
Closed
midnightstardust wants to merge 9 commits intopython:mainfrom
Closed
gh-109252: Remove leading whitespace email#122617midnightstardust wants to merge 9 commits intopython:mainfrom
midnightstardust wants to merge 9 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
…ythonGH-122577) The `PyStructSequence` destructor would crash if it was deallocated after its type's dictionary was cleared by the GC, because it couldn't compute the "real size" of the instance. This could occur with relatively straightforward code in the free-threaded build or with a reference cycle involving the type in the default build, due to differing orders in which `tp_clear()` was called. Account for the non-sequence fields in `tp_basicsize` and use that, along with `Py_SIZE()`, to compute the "real" size of a `PyStructSequence` in the dealloc function. This avoids the accesses to the type's dictionary during dealloc, which were unsafe.
| @@ -0,0 +1 @@ | |||
| Fixed an existing issue with email header lib adding whitespace | |||
Member
There was a problem hiding this comment.
I don't like how this entry is worded. How about something like this?
Suggested change
| Fixed an existing issue with email header lib adding whitespace | |
| Fixed :mod:`email` preserving leading whitespace in wrapped headers. |
Member
|
Looks like this doesn't fully fix #109252. The original reproducer still gives the same error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an existing old issue with the whitespace by making a small change. This is my first PR to cpython so thanks for taking the time to review this and opening the issue.