gh-84808: Handle errors returned by internal_connect()#122304
gh-84808: Handle errors returned by internal_connect()#122304encukou merged 3 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@korli: Did that help? Do you need more info? |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
2 similar comments
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
picnixz
dismissed
their stale review
Changes were made (just a missing NEWS entry, if needed)
internal_connect() errors when returning -1 with exception set. reported and proposed by Ryan C. Gordon error handling scheme (raise, no raise) as suggested by encukou Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
Thank you!
I'll touch up the NEWS entry to mention user-facing API, and merge.
In the future, please don't rebase pull requests to CPython. Rebasing throws away the previously reviewed commits, so all of the PR needs to be reviewed again.
But on small PRs like this one, it's not much of a problem :)
Misc/NEWS.d/next/Library/2024-09-06-10-17-54.gh-issue-84808.ION67Z.rst
Outdated
Show resolved
Hide resolved
Thank you!
Indeed, sorry I'm used to push clean commits. |
3 participants
Python shouldn't assume that errno codes are positive.
reported and proposed by Ryan C. Gordon