X Tutup
Skip to content

gh-117482: Expand Tests for Slot Wrappers of Inherited Slots of Static Builtin Types#122192

Merged
ericsnowcurrently merged 2 commits intopython:mainfrom
ericsnowcurrently:test-builtin-types-inherited-slots
Jul 23, 2024
Merged

gh-117482: Expand Tests for Slot Wrappers of Inherited Slots of Static Builtin Types#122192
ericsnowcurrently merged 2 commits intopython:mainfrom
ericsnowcurrently:test-builtin-types-inherited-slots

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Jul 23, 2024 •
edited by bedevere-app bot
Loading

We make the existing test more exhaustive and add a test for a re-initialized runtime.

@bedevere-app bedevere-app bot mentioned this pull request Jul 23, 2024
Open
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Jul 23, 2024
@ericsnowcurrently ericsnowcurrently added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 23, 2024
@ericsnowcurrently ericsnowcurrently enabled auto-merge (squash) July 23, 2024 19:38
@ericsnowcurrently ericsnowcurrently merged commit 33d32fa into python:main Jul 23, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 23, 2024

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2024
@ericsnowcurrently @miss-islington
pythongh-117482: Expand Tests for Slot Wrappers of Inherited Slots of…
e4d5279 
… Static Builtin Types (pythongh-122192)

(cherry picked from commit 33d32fa)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 23, 2024

Sorry, @ericsnowcurrently, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 33d32faa580fb776cb660e9cc8aa7e45c6c68c08 3.12

@bedevere-app
Copy link

bedevere-app bot commented Jul 23, 2024

GH-122195 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 23, 2024
@ericsnowcurrently ericsnowcurrently deleted the test-builtin-types-inherited-slots branch July 23, 2024 20:13
@bedevere-bot
Copy link

bedevere-bot commented Jul 23, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL Refleaks 3.x has failed when building commit 33d32fa.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1226/builds/2306) and take a look at the build logs.
  4. Check if the failure is related to this commit (33d32fa) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1226/builds/2306

Failed tests:

  • test_types

Test leaking resources:

  • test_types: references

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 6, done.        
remote: Counting objects:  16% (1/6)        
remote: Counting objects:  33% (2/6)        
remote: Counting objects:  50% (3/6)        
remote: Counting objects:  66% (4/6)        
remote: Counting objects:  83% (5/6)        
remote: Counting objects: 100% (6/6)        
remote: Counting objects: 100% (6/6), done.        
remote: Compressing objects:  20% (1/5)        
remote: Compressing objects:  40% (2/5)        
remote: Compressing objects:  60% (3/5)        
remote: Compressing objects:  80% (4/5)        
remote: Compressing objects: 100% (5/5)        
remote: Compressing objects: 100% (5/5), done.        
remote: Total 6 (delta 1), reused 1 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '33d32faa580fb776cb660e9cc8aa7e45c6c68c08'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 33d32faa58 gh-117482: Expand Tests for Slot Wrappers of Inherited Slots of Static Builtin Types (gh-122192)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)

make: *** [Makefile:2267: buildbottest] Error 2

ericsnowcurrently added a commit that referenced this pull request Jul 23, 2024
@miss-islington @ericsnowcurrently
[3.13] gh-117482: Expand Tests for Slot Wrappers of Inherited Slots o…
1d601a1 
…f Static Builtin Types (gh-122195)

(cherry picked from commit 33d32fa, AKA gh-122192)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Jul 23, 2024
@ericsnowcurrently
pythongh-117482: Expand Tests for Slot Wrappers of Inherited Slots of…
34cb17d 
… Static Builtin Types (pythongh-122192)
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 23, 2024
Merged
@bedevere-app
Copy link

bedevere-app bot commented Jul 23, 2024

GH-122197 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 23, 2024
@ericsnowcurrently
Copy link
Member Author

ericsnowcurrently commented Jul 23, 2024

FYI, I'll have the ref leak sorted out soon.

@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 23, 2024
Open
ericsnowcurrently added a commit that referenced this pull request Jul 23, 2024
@ericsnowcurrently
[3.12] gh-117482: Expand Tests for Slot Wrappers of Inherited Slots o…
d7c67e0 
…f Static Builtin Types (gh-122197)

(cherry picked from commit 33d32fa, AKA gh-122192)
@ericsnowcurrently
Copy link
Member Author

ericsnowcurrently commented Jul 23, 2024

The fix is in: gh-122200.

nohlson pushed a commit to nohlson/cpython that referenced this pull request Jul 24, 2024
@ericsnowcurrently @nohlson
pythongh-117482: Expand Tests for Slot Wrappers of Inherited Slots of…
dac02c1 
… Static Builtin Types (pythongh-122192)
nohlson pushed a commit to nohlson/cpython that referenced this pull request Jul 24, 2024
@ericsnowcurrently @nohlson
pythongh-117482: Expand Tests for Slot Wrappers of Inherited Slots of…
6568455 
… Static Builtin Types (pythongh-122192)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ericsnowcurrently ericsnowcurrently

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericsnowcurrently @bedevere-bot
X Tutup