X Tutup
Skip to content

gh-120289: Add external timer in traverse of _lsprof.Profiler#121998

Merged
gaogaotiantian merged 1 commit intopython:mainfrom
gaogaotiantian:fix-lsprof-refleak
Jul 19, 2024
Merged

gh-120289: Add external timer in traverse of _lsprof.Profiler#121998
gaogaotiantian merged 1 commit intopython:mainfrom
gaogaotiantian:fix-lsprof-refleak

Conversation

@gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Jul 19, 2024 •
edited by bedevere-app bot
Loading

It turned out that we did not include the external timer in tp_traverse, and the external timer could be a container that causes a ref cycle - this could lead to ref leak.

Confirmed that ./python -m test -R3:3 test_cprofile passed after the change.

@bedevere-app bedevere-app bot mentioned this pull request Jul 19, 2024
Closed
@gaogaotiantian gaogaotiantian added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 19, 2024
@gaogaotiantian gaogaotiantian mentioned this pull request Jul 19, 2024
Merged
@gaogaotiantian
Copy link
Member Author

gaogaotiantian commented Jul 19, 2024

@colesbury maybe you could take a quick look at this?

@gaogaotiantian
Copy link
Member Author

gaogaotiantian commented Jul 19, 2024

Thanks!

@gaogaotiantian gaogaotiantian merged commit eaf094c into python:main Jul 19, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 19, 2024

Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@gaogaotiantian gaogaotiantian deleted the fix-lsprof-refleak branch July 19, 2024 03:46
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@gaogaotiantian @miss-islington
pythongh-120289: Add external timer in traverse of _lsprof.Profiler (p…
945f206 
…ythonGH-121998)

(cherry picked from commit eaf094c)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@gaogaotiantian @miss-islington
pythongh-120289: Add external timer in traverse of _lsprof.Profiler (p…
b8719f7 
…ythonGH-121998)

(cherry picked from commit eaf094c)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2024

GH-122000 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2024

GH-122001 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 19, 2024
gaogaotiantian added a commit that referenced this pull request Jul 19, 2024
@miss-islington @gaogaotiantian
[3.12] gh-120289: Add external timer in traverse of _lsprof.Profiler (G…
0403cb4 
…H-121998) (#122001)

gh-120289: Add external timer in traverse of _lsprof.Profiler (GH-121998)
(cherry picked from commit eaf094c)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
gaogaotiantian added a commit that referenced this pull request Jul 19, 2024
@miss-islington @gaogaotiantian
[3.13] gh-120289: Add external timer in traverse of _lsprof.Profiler (G…
e992cc3 
…H-121998) (#122000)

gh-120289: Add external timer in traverse of _lsprof.Profiler (GH-121998)
(cherry picked from commit eaf094c)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 19, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora 3.13 has failed when building commit e992cc3.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1403/builds/215) and take a look at the build logs.
  4. Check if the failure is related to this commit (e992cc3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1403/builds/215

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_inspect_keeps_globals_from_inspected_module - test.test_pyrepl.test_pyrepl.TestMain.test_inspect_keeps_globals_from_inspected_module

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
    self.fail(f"{var}= not found in output")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: __package__= not found in output


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
    self.fail(f"{var}= not found in output")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: FOO= not found in output


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
    self.fail(f"{var}= not found in output")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: __name__= not found in output


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
    self.fail(f"{var}= not found in output")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: __file__= not found in output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gaogaotiantian @bedevere-bot @colesbury @serhiy-storchaka
X Tutup