X Tutup
Skip to content

gh-121657: Display correct error message for yield from outside of a …#121680

Merged
encukou merged 3 commits intopython:mainfrom
gege-hoho:fix-issue-121657
Jul 13, 2024
Merged

gh-121657: Display correct error message for yield from outside of a …#121680
encukou merged 3 commits intopython:mainfrom
gege-hoho:fix-issue-121657

Conversation

@gege-hoho
Copy link
Contributor

@gege-hoho gege-hoho commented Jul 13, 2024 •
edited by bedevere-app bot
Loading

Display correct error message for yield from outside of a function

@ghost
Copy link

ghost commented Jul 13, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Jul 13, 2024
Closed
picnixz
picnixz reviewed Jul 13, 2024
View reviewed changes
Lib/test/test_generators.py
...
SyntaxError: 'yield' outside function

>>> yield from [1,2]
Copy link
Member

@picnixz picnixz Jul 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a test with lambda as well since they are "almost like" functions (but not from a compiler PoV).

Copy link
Contributor Author

@gege-hoho gege-hoho Jul 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it in a seperate PR

Copy link
Contributor Author

@gege-hoho gege-hoho Jul 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added another test as requested in #121722

@gege-hoho @picnixz
Update Misc/NEWS.d/next/Core and Builtins/2024-07-13-12-27-31.gh-issu…
5ea0d5f 
…e-121657.wgOYLw.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@encukou encukou merged commit 178e44d into python:main Jul 13, 2024
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 13, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 13, 2024

Thanks @gege-hoho for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Jul 13, 2024

Thanks @gege-hoho for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Jul 13, 2024

Sorry, @gege-hoho and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 178e44de8f023be7a5dc400044ab61983b191f24 3.13

@miss-islington-app
Copy link

miss-islington-app bot commented Jul 13, 2024

Sorry, @gege-hoho and @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 178e44de8f023be7a5dc400044ab61983b191f24 3.12

Eclips4 pushed a commit to Eclips4/cpython that referenced this pull request Jul 14, 2024
@gege-hoho @blurb-it
@picnixz @Eclips4
[3.13] pythongh-121657: Display correct error message for yield from …
a22d2b5 
…outside of a function (pythonGH-121680)

(cherry picked from commit 178e44d)

Co-authored-by: Gregor <36135323+gege-hoho@users.noreply.github.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@Eclips4 Eclips4 mentioned this pull request Jul 14, 2024
Merged
@bedevere-app
Copy link

bedevere-app bot commented Jul 14, 2024

GH-121768 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 14, 2024
@Eclips4 Eclips4 mentioned this pull request Jul 14, 2024
Merged
@bedevere-app
Copy link

bedevere-app bot commented Jul 14, 2024

GH-121769 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 14, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@gege-hoho @blurb-it
@picnixz @estyxx
pythongh-121657: Display correct error message for yield from outside…
6300a9c 
… of a function (pythonGH-121680)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees

@encukou encukou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gege-hoho @picnixz @encukou
X Tutup