gh-117482: Fix Builtin Types Slot Wrappers When Embedded#121636
gh-117482: Fix Builtin Types Slot Wrappers When Embedded#121636ericsnowcurrently wants to merge 10 commits intopython:mainfrom
Conversation
ericsnowcurrently
added
skip news
needs backport to 3.13
|
I feel like while we are at it, properly implementing a full cleanup of the runtime state as mentioned in the |
|
Yep. It's on my TODO list. 😄 |
ericsnowcurrently
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 8520cfc 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 8520cfc 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
I'm going to go with gh-122865. We can circle back to this later. |
4 participants
While gh-121602 solved most of the problem, it did not resolve the case where the runtime gets re-initialized. In that case, we end up in the same situation as before, where the inherited "tp" slots are set, which makes
add_operators()do the wrong thing. We fix that by resetting the static type to the preserved values during finalization. We also make sure the type substructs are preserved.(Given that this fix is for a more unlikely case, I'm inclined to not backport this to 3.12.)
int.__str__behaviour inside sub-interpreters #117482