[3.13] gh-121368: Fix seq lock memory ordering in _PyType_Lookup (GH-121388)#121505
Merged
colesbury merged 1 commit intopython:3.13from Jul 8, 2024
Merged
[3.13] gh-121368: Fix seq lock memory ordering in _PyType_Lookup (GH-121388)#121505colesbury merged 1 commit intopython:3.13from
colesbury merged 1 commit intopython:3.13from
Conversation
…onGH-121388) The `_PySeqLock_EndRead` function needs an acquire fence to ensure that the load of the sequence happens after any loads within the read side critical section. The missing fence can trigger bugs on macOS arm64. Additionally, we need a release fence in `_PySeqLock_LockWrite` to ensure that the sequence update is visible before any modifications to the cache entry. (cherry picked from commit 1d3cf79) Co-authored-by: Sam Gross <colesbury@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_PySeqLock_EndReadfunction needs an acquire fence to ensure thatthe load of the sequence happens after any loads within the read side
critical section. The missing fence can trigger bugs on macOS arm64.
Additionally, we need a release fence in
_PySeqLock_LockWritetoensure that the sequence update is visible before any modifications to
the cache entry.
(cherry picked from commit 1d3cf79)
Co-authored-by: Sam Gross colesbury@gmail.com