X Tutup
Skip to content

gh-121188: Escape invalid XML characters in regrtest#121195

Merged
vstinner merged 3 commits intopython:mainfrom
vstinner:regrtest_xml
Jul 1, 2024
Merged

gh-121188: Escape invalid XML characters in regrtest#121195
vstinner merged 3 commits intopython:mainfrom
vstinner:regrtest_xml

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jul 1, 2024 •
edited by bedevere-app bot
Loading

When creating the JUnit XML file, regrtest now escapes characters which are invalid in XML, such as the chr(27) control character used in ANSI escape sequences.

@vstinner
pythongh-121188: Escape invalid XML characters in regrtest
9753167 
When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
@bedevere-app bedevere-app bot mentioned this pull request Jul 1, 2024
Closed
@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed awaiting core review labels Jul 1, 2024
serhiy-storchaka
serhiy-storchaka reviewed Jul 1, 2024
View reviewed changes
@vstinner
Copy link
Member Author

vstinner commented Jul 1, 2024

@serhiy-storchaka: I addressed your review (I applied your suggestions). Please review the updated PR.

serhiy-storchaka
serhiy-storchaka approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner enabled auto-merge (squash) July 1, 2024 08:18
@vstinner
Copy link
Member Author

vstinner commented Jul 1, 2024

!buildbot s390x SLES PR

@bedevere-bot
Copy link

bedevere-bot commented Jul 1, 2024

🤖 New build scheduled with the buildbot fleet by @vstinner for commit b2ffbe4 🤖

The command will test the builders whose names match following regular expression: s390x SLES PR

The builders matched are:

  • s390x SLES PR

@vstinner vstinner merged commit af8c3d7 into python:main Jul 1, 2024
@vstinner vstinner deleted the regrtest_xml branch July 1, 2024 08:30
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 1, 2024

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
@vstinner @miss-islington
pythongh-121188: Sanitize invalid XML characters in regrtest (pythonG…
09beeed 
…H-121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
(cherry picked from commit af8c3d7)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Jul 1, 2024

GH-121204 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
@vstinner @miss-islington
pythongh-121188: Sanitize invalid XML characters in regrtest (pythonG…
c1c3fbe 
…H-121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
(cherry picked from commit af8c3d7)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 1, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 1, 2024

GH-121205 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 1, 2024
@vstinner
Copy link
Member Author

vstinner commented Jul 1, 2024

Merged, thanks your help @serhiy-storchaka!

vstinner added a commit that referenced this pull request Jul 1, 2024
@miss-islington @vstinner
[3.12] gh-121188: Sanitize invalid XML characters in regrtest (GH-121195
b80edaf 
) (#121205)

gh-121188: Sanitize invalid XML characters in regrtest (GH-121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
(cherry picked from commit af8c3d7)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Jul 1, 2024
@miss-islington @vstinner
[3.13] gh-121188: Sanitize invalid XML characters in regrtest (GH-121195
1f2f9c4 
) (#121204)

gh-121188: Sanitize invalid XML characters in regrtest (GH-121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
(cherry picked from commit af8c3d7)

Co-authored-by: Victor Stinner <vstinner@python.org>
Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
@vstinner @Akasurde
pythongh-121188: Sanitize invalid XML characters in regrtest (python#…
a95fdf1 
…121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vstinner @noahbkim
pythongh-121188: Sanitize invalid XML characters in regrtest (python#…
dc5f7c0 
…121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-121188: Sanitize invalid XML characters in regrtest (python#…
45d3d42 
…121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @bedevere-bot @serhiy-storchaka
X Tutup