gh-120495: Fix incorrect exception handling in Tab Nanny#120498
Merged
hugovk merged 5 commits intopython:mainfrom Jun 15, 2024
Merged
gh-120495: Fix incorrect exception handling in Tab Nanny#120498hugovk merged 5 commits intopython:mainfrom
hugovk merged 5 commits intopython:mainfrom
Conversation
hugovk
reviewed
Jun 14, 2024
hugovk
reviewed
Jun 14, 2024
Misc/NEWS.d/next/Library/2024-06-14-20-05-25.gh-issue-120495.OxgZKB.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
aisk
approved these changes
Jun 14, 2024
Member
|
Please check the test failure: |
Member
|
Before, the indentation test except SyntaxError as msg:
errprint("%r: Token Error: %s" % (file, msg))
returnBut now, it's hitting the correct one: except IndentationError as msg:
errprint("%r: Indentation Error: %s" % (file, msg))
returnSo we need to fix the test to look for the correct "Indentation Error" text. Please could you update the test? |
Contributor
Author
|
I need to change the https://github.com/python/cpython/blob/main/Lib/test/test_tabnanny.py#L318-L319 ? |
Member
|
That's right, change "Token Error" to "Indentation Error" :) |
|
Thanks @Wulian233 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2024
…nGH-120498) (cherry picked from commit c501261) Co-authored-by: Wulian233 <71213467+Wulian233@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2024
…nGH-120498) (cherry picked from commit c501261) Co-authored-by: Wulian233 <71213467+Wulian233@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-120548 is a backport of this pull request to the 3.13 branch. |
|
GH-120549 is a backport of this pull request to the 3.12 branch. |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…n#120498) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…n#120498) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…n#120498) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue, need backport to 3.13?