gh-120380: fix Python implementation of pickle.Pickler for bytes and bytearray objects in protocol version 5.#120422
Merged
encukou merged 14 commits intopython:mainfrom Jun 21, 2024
Merged
Conversation
Member
Author
|
I'll fix the |
Member
Author
|
The |
encukou
reviewed
Jun 18, 2024
Member
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
Thank you for the fix!
I have a few suggestions.
The test_pyclbr fix would be better off in a separate PR.
Member
Author
|
The |
This reverts commit 236efc0360a8e1ccfb8890845c2e75944e836179.
This reverts commit 13c969d.
encukou
added
needs backport to 3.12
Member
|
Thank you! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 21, 2024
…ytes` and `bytearray` objects in protocol version 5. (pythonGH-120422) (cherry picked from commit 7595e67) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 21, 2024
…ytes` and `bytearray` objects in protocol version 5. (pythonGH-120422) (cherry picked from commit 7595e67) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-120832 is a backport of this pull request to the 3.13 branch. |
|
GH-120833 is a backport of this pull request to the 3.12 branch. |
encukou
pushed a commit
that referenced
this pull request
Jun 26, 2024
…bytes` and `bytearray` objects in protocol version 5. (GH-120422) (GH-120832) gh-120380: fix Python implementation of `pickle.Pickler` for `bytes` and `bytearray` objects in protocol version 5. (GH-120422) (cherry picked from commit 7595e67) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
encukou
pushed a commit
that referenced
this pull request
Jun 26, 2024
…bytes` and `bytearray` objects in protocol version 5. (GH-120422) (GH-120833) gh-120380: fix Python implementation of `pickle.Pickler` for `bytes` and `bytearray` objects in protocol version 5. (GH-120422) (cherry picked from commit 7595e67) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…ytes` and `bytearray` objects in protocol version 5. (pythonGH-120422)
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…ytes` and `bytearray` objects in protocol version 5. (pythonGH-120422)
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…ytes` and `bytearray` objects in protocol version 5. (pythonGH-120422)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is not only for the one in #120380 but also affected 0-copy bytes objects. Actually, the issue is only for the empty case.
I'm not entirely sure it's the simplest way to do it and whether I could perhaps just special-case the empty case.