GH-118289: Fix handling of non-directories in posixpath.realpath()#120127
Merged
barneygale merged 4 commits intopython:mainfrom Nov 13, 2024
Merged
GH-118289: Fix handling of non-directories in posixpath.realpath()#120127barneygale merged 4 commits intopython:mainfrom
posixpath.realpath()#120127barneygale merged 4 commits intopython:mainfrom
Conversation
In strict mode, raise `NotADirectoryError` if we encounter a non-directory while we still have path parts left to process. We use a `part_count` variable rather than `len(rest)` because the `rest` stack also contains markers for unresolved symlinks.
Contributor
Author
|
Follow-up to #118290, where I messed up a rebase and notified everyone (whoops!) |
serhiy-storchaka
approved these changes
Jun 17, 2024
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. Thanks.
How does it work on Windows? Could you add generic tests for these cases?
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Thanks for the review, Serhiy. Playing around with this in Windows, it seems that |
barneygale
changed the title
os.path.realpath()posixpath.realpath()
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @barneygale, I could not cleanly backport this to |
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Nov 13, 2024
….realpath()` (pythonGH-120127) In strict mode, raise `NotADirectoryError` if we encounter a non-directory while we still have path parts left to process. We use a `part_count` variable rather than `len(rest)` because the `rest` stack also contains markers for unresolved symlinks.. (cherry picked from commit fd4b545) Co-authored-by: Barney Gale <barney.gale@gmail.com>
|
GH-126815 is a backport of this pull request to the 3.13 branch. |
barneygale
added a commit
that referenced
this pull request
Nov 13, 2024
…ath()` (GH-120127) (#126815) In strict mode, raise `NotADirectoryError` if we encounter a non-directory while we still have path parts left to process. We use a `part_count` variable rather than `len(rest)` because the `rest` stack also contains markers for unresolved symlinks. (cherry picked from commit fd4b545)
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…th()` (python#120127) In strict mode, raise `NotADirectoryError` if we encounter a non-directory while we still have path parts left to process. We use a `part_count` variable rather than `len(rest)` because the `rest` stack also contains markers for unresolved symlinks.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…th()` (python#120127) In strict mode, raise `NotADirectoryError` if we encounter a non-directory while we still have path parts left to process. We use a `part_count` variable rather than `len(rest)` because the `rest` stack also contains markers for unresolved symlinks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In strict mode, raise
NotADirectoryErrorif we encounter a non-directory while we still have path parts left to process.We use a
part_countvariable rather thanlen(rest)because thereststack also contains markers for unresolved symlinks.os.path.realpath('notadir/', strict=True)doesn't raise #118289