gh-119689: generate stack effect metadata for pseudo instructions#119691
Merged
iritkatriel merged 5 commits intopython:mainfrom May 29, 2024
Merged
gh-119689: generate stack effect metadata for pseudo instructions#119691iritkatriel merged 5 commits intopython:mainfrom
iritkatriel merged 5 commits intopython:mainfrom
Conversation
iritkatriel
added
the
interpreter-core
gvanrossum
approved these changes
May 29, 2024
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
LGTM, though I'm not sure what should happen to the jump argument.
| @@ -703,51 +703,22 @@ compiler_set_qualname(struct compiler *c) | |||
| static int | |||
| stack_effect(int opcode, int oparg, int jump) | |||
Member
There was a problem hiding this comment.
Is jump still used? The deleted SETUP cases use it, but I don't think the generated code uses it. Is it no longer needed? Could you remove the jump argument then? (All the callers are inside this file.)
Member
Author
There was a problem hiding this comment.
jump is exposed in the c api and used from flowgraph.c.
Member
There was a problem hiding this comment.
I see, the key is IS_BLOCK_PUSH_OPCODE(opcode). Sorry I didn't get that at first.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119689.