gh-118673: Remove shebang and executable bits from stdlib modules.#119658
Merged
jaraco merged 2 commits intopython:mainfrom May 29, 2024
Merged
gh-118673: Remove shebang and executable bits from stdlib modules.#119658jaraco merged 2 commits intopython:mainfrom
jaraco merged 2 commits intopython:mainfrom
Conversation
jaraco
requested review from
merwok
and removed request for
a team and
ethanfurman
jaraco
force-pushed
the
feature/no-exe-modules
branch
2 times, most recently
from
e791199 to
ac81766
Compare
The setting was inappropriate for '__main__' and inconsistent across the other modules. The scripts can still be executed directly by invoking with the desired interpreter.
jaraco
force-pushed
the
feature/no-exe-modules
branch
from
ac81766 to
97b8138
Compare
Member
Author
|
I was unsure whether turtledemo should have its shebangs removed, as the documentation specifically states that the individual modules can be run independently. But given that (a) the files have |
gpshead
approved these changes
May 29, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…es. (python#119658) * pythongh-118673: Remove shebang and executable bits from stdlib modules. * Removed shebangs and exe bits on turtledemo scripts. The setting was inappropriate for '__main__' and inconsistent across the other modules. The scripts can still be executed directly by invoking with the desired interpreter.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…es. (python#119658) * pythongh-118673: Remove shebang and executable bits from stdlib modules. * Removed shebangs and exe bits on turtledemo scripts. The setting was inappropriate for '__main__' and inconsistent across the other modules. The scripts can still be executed directly by invoking with the desired interpreter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118673
Note that while this change removes shebangs from many modules in the standard library, this approach does not set a precedent that shebangs are discouraged. Shebangs and executable bits are still allowed and supported in situations deemed appropriate. Some of these changes may be reverted if it is determined their presence is adding significant value.