X Tutup
Skip to content

gh-119205: Fix autocompletion bug in new repl #119229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 15 commits into from
May 21, 2024
Merged

gh-119205: Fix autocompletion bug in new repl #119229

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8a0241f
gh-119205: Fix autocompletion bug in new repl
koxudaxi May 20, 2024
05c271b
Merge branch 'main' into fix-issue-119205
koxudaxi May 20, 2024
852cd53
📜🤖 Added by blurb_it.
blurb-it[bot] May 20, 2024
f9ee809
gh-119205: Add unittest
koxudaxi May 20, 2024
22cdb57
Merge branch 'main' into fix-issue-119205
koxudaxi May 20, 2024
241e634
gh-119205: revert unnecessary changes
koxudaxi May 20, 2024
e5f1575
gh-119205: revert unnecessary changes
koxudaxi May 20, 2024
b2f1b02
gh-119205: Improve unittest
koxudaxi May 20, 2024
6509c29
gh-119205: Improve suppression warning
koxudaxi May 20, 2024
3d41951
Merge branch 'main' into fix-issue-119205
koxudaxi May 21, 2024
e8988b8
Merge branch 'main' into fix-issue-119205
ambv May 21, 2024
fe484c7
Remove news
ambv May 21, 2024
a1e81f5
Merge branch 'main' into fix-issue-119205
koxudaxi May 21, 2024
159f9d8
Merge branch 'main' into fix-issue-119205
koxudaxi May 21, 2024
11c3a18
Merge branch 'main' into fix-issue-119205
koxudaxi May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-119205: Improve unittest
  • Loading branch information
@koxudaxi
koxudaxi committed May 20, 2024
commit b2f1b028f3c151a50adea83c4d19ed4ef1905c59
14 changes: 6 additions & 8 deletions Lib/test/test_pyrepl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
readline = import_module("readline")

from _pyrepl.console import Console, Event
from _pyrepl.readline import ReadlineAlikeReader, ReadlineConfig
from _pyrepl.readline import ReadlineAlikeReader, ReadlineConfig, multiline_input as readline_multiline_input
from _pyrepl.simple_interact import _strip_final_indent
from _pyrepl.unix_eventqueue import EventQueue
from _pyrepl.input import KeymapTranslator
Expand Down Expand Up @@ -633,7 +633,8 @@ def test_updown_arrow_with_completion_menu(self):
self.assertEqual(output, "os.")

@patch("_pyrepl.readline._ReadlineWrapper.get_reader")
def test_completion_with_warnings(self, mock_get_reader):
@patch("sys.stderr", new_callable=io.StringIO)
def test_completion_with_warnings(self, mock_stderr, mock_get_reader):
class Dummy:
@property
def test_func(self):
Expand All @@ -645,13 +646,10 @@ def test_func(self):
events = code_to_events("dummy.test_func.\t\n\n")
namespace = {"dummy": dummy}
reader = self.prepare_reader(events, namespace)
from _pyrepl.readline import multiline_input as readline_multiline_input
with patch("_pyrepl.readline._ReadlineWrapper.get_reader", lambda _: reader), \
patch("sys.stderr", new_callable=io.StringIO) as f:
output = readline_multiline_input(more_lines, ">>>", "...")

mock_get_reader.return_value = reader
output = readline_multiline_input(more_lines, ">>>", "...")
self.assertEqual(output[0], "dummy.test_func.")
self.assertEqual(f.getvalue(), "")
self.assertEqual(mock_stderr.getvalue(), "")


@patch("_pyrepl.curses.tigetstr", lambda x: b"")
Expand Down
X Tutup