gh-118771: Ensure names defined in optimizer.h start with Py/_Py#118825
Merged
encukou merged 4 commits intopython:mainfrom May 10, 2024
Merged
gh-118771: Ensure names defined in optimizer.h start with Py/_Py#118825encukou merged 4 commits intopython:mainfrom
encukou merged 4 commits intopython:mainfrom
Conversation
28 tasks
Member
|
I'll leave this for @markshannon to review. |
Member
|
I personally don't think we should be exposing this much of the micro-op format. Can they just be moved to |
Member
|
Yes, let's move as much as we can to |
markshannon
approved these changes
May 10, 2024
Member
markshannon
left a comment
There was a problem hiding this comment.
@encukou Thanks for tidying that up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimizer.his included fromPython.h, and defines some names that can clash with user code. They should be hidden or get thePy/_Pyprefix.This PR:
struct _bloom_filterstruct _exit_data_Py_:uop_get_targetuop_get_exit_indexuop_get_jump_targetuop_get_error_targetoptimize_functypedefBLOOM_FILTER_WORDSUOP_FORMAT_TARGETUOP_FORMAT_EXITUOP_FORMAT_JUMPUOP_FORMAT_UNUSEDPerhaps some of these should be in a private header instead?
Or perhaps some should be public?
@markshannon, could you clarify the intent here?
Py/_Pyprefix #118771