GH-115775: Use __static_attributes__ to initialize shared keys#118468
Conversation
|
No need for news item as it is covered by #117909 |
dedffa7 to
5032ad9
Compare
846a7ef to
a7b858b
Compare
b64de3d to
d54afaf
Compare
|
The stats are not obviously better. This PR reduces misses in Both From this, it appears that this PR does what it aims to do. It also appears that it would be worth improving our handling of shadowed attributes. I plan to fix the shadowing issue before merging this, so that it becomes a clear improvement |
|
Now that #123040 is fixed things look much better. Performance shows no change apart from the "go" benchmark speeds up by 35%. The "go" benchmark creates many objects before initializing them, which is a pattern that this PR allows us to optimize. The stats show a small increase in specialization of |
Uh oh!
There was an error while loading. Please reload this page.