GH-117714: implement athrow().close() and asend().close() using throw#117906
Merged
encukou merged 4 commits intopython:mainfrom May 6, 2024
Merged
GH-117714: implement athrow().close() and asend().close() using throw#117906encukou merged 4 commits intopython:mainfrom
encukou merged 4 commits intopython:mainfrom
Conversation
graingert
changed the title
graingert
force-pushed
the
gen-close-as-throw
branch
2 times, most recently
from
e9116f3 to
743ded1
Compare
graingert
changed the title
graingert
changed the title
graingert
force-pushed
the
gen-close-as-throw
branch
from
7b46d8e to
8e1fb97
Compare
graingert
force-pushed
the
gen-close-as-throw
branch
from
8e1fb97 to
e351047
Compare
encukou
approved these changes
May 6, 2024
Member
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
I agree.
It takes time to wrap my head around this, though :)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Contributor
Author
|
@encukou is this change too much like a feature to be backported to 3.12? |
|
Thanks @graingert for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 6, 2024
… throw (pythonGH-117906) * pythonGH-117714: replace athrow().close() and asend().close() stubs with implimentations * test athrow().close() and asend().close() raises RuntimeError * 📜🤖 Added by blurb_it. * Update Objects/genobject.c Co-authored-by: Petr Viktorin <encukou@gmail.com> --------- (cherry picked from commit e5c6992) Co-authored-by: Thomas Grainger <tagrain@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
GH-118663 is a backport of this pull request to the 3.12 branch. |
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
… throw (pythonGH-117906) * pythonGH-117714: replace athrow().close() and asend().close() stubs with implimentations * test athrow().close() and asend().close() raises RuntimeError * 📜🤖 Added by blurb_it. * Update Objects/genobject.c Co-authored-by: Petr Viktorin <encukou@gmail.com> --------- Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.