bpo-35903: Use autoconfig to probe for shm_open() and shm_unlink().#11765
Merged
nascheme merged 4 commits intopython:masterfrom Feb 8, 2019
Merged
bpo-35903: Use autoconfig to probe for shm_open() and shm_unlink().#11765nascheme merged 4 commits intopython:masterfrom
nascheme merged 4 commits intopython:masterfrom
Conversation
AC_SEARCH_LIBS will execute the success clause even if -lrt is not needed. So, check the result and define HAVE_RT_SHM_OPEN only if linking with -lrt is really needed.
Member
|
That looks like a winner to me. Given all the other discussions going on around shared memory at the moment, it might be worth holding off merging right away... or would that actually be counter-productive? |
Member
Author
|
I would be inclined to merge. It is easy to back out if needed but I think it makes things better. I understand the plan is to not revert your e5ef45b change. |
|
@nascheme: Please replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic in setup.py that determines if _multiprocessing/posixshmem.c should get built is not very robust. I think it is better to use autoconfig to probe for the required functions and libraries. My autoconfig brain cells are a bit fuzzy but I think my patch is correct.
I look for shm_open and shm_unlink. I also check if librt is required for these functions.
https://bugs.python.org/issue35903