X Tutup
Skip to content

gh-117557: Improve error messages when a string, bytes or bytearray of length 1 are expected#117631

Merged
serhiy-storchaka merged 11 commits intopython:mainfrom
serhiy-storchaka:parse-single-char-errors
May 28, 2024
Merged

gh-117557: Improve error messages when a string, bytes or bytearray of length 1 are expected#117631
serhiy-storchaka merged 11 commits intopython:mainfrom
serhiy-storchaka:parse-single-char-errors

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 8, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting core review labels Apr 8, 2024
@serhiy-storchaka serhiy-storchaka force-pushed the parse-single-char-errors branch from 15ff9a3 to 308f7a2 Compare April 8, 2024 10:53
@serhiy-storchaka serhiy-storchaka requested a review from a team as a code owner April 8, 2024 10:53
erlend-aasland
erlend-aasland approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice; thanks, Serhiy!

I left some comments.

@erlend-aasland erlend-aasland changed the title gh-117558: Improve error messages when a string, bytes or bytearray of length 1 are expected gh-117557: Improve error messages when a string, bytes or bytearray of length 1 are expected Apr 8, 2024
@bedevere-app bedevere-app bot mentioned this pull request Apr 8, 2024
Closed
@erlend-aasland erlend-aasland mentioned this pull request Apr 8, 2024
Closed
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Apr 8, 2024

Right, %T, not %N. It's too new 😆 re. 054f12f

erlend-aasland
erlend-aasland approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

serhiy-storchaka
serhiy-storchaka commented Apr 8, 2024
View reviewed changes
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Apr 8, 2024

I am not sure about articles. It is a puzzle to me whether they should be used, and whether not.

erlend-aasland
erlend-aasland reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these suggestions are correct, but I'd like them to be verified by a native speaker.

@serhiy-storchaka @erlend-aasland
Apply suggestions from code review
c40f344 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Apr 8, 2024

@terryjreedy, could you please take a look?

terryjreedy
terryjreedy requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the tests non-clinic python code carefully and tried the check the logic of the rest. It seems that there are more error cases that error tests, so I wonder if all were covered in a test.

Over all I really like the patch.

@bedevere-app
Copy link

bedevere-app bot commented Apr 8, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Apr 15, 2024

I have made the requested changes; please review again.

Although I am not sure that I have made them all. There is a variety in wording, and some examples look contradictory.

"a unicode character", "str of length 1", "string of length 1" -- refers to str of length 1.
"one character bytes", "a single byte", "bytes of length 1", "a byte string of length 1", "bytes object of length 1" -- refers to bytes (or bytearray) of length 1.

@bedevere-app
Copy link

bedevere-app bot commented Apr 15, 2024

Thanks for making the requested changes!

@erlend-aasland, @terryjreedy: please review the changes made to this pull request.

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented May 22, 2024

@terryjreedy, could you please take another look?

@serhiy-storchaka serhiy-storchaka merged commit b313cc6 into python:main May 28, 2024
@serhiy-storchaka serhiy-storchaka deleted the parse-single-char-errors branch May 28, 2024 09:01
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-117557: Improve error messages when a string, bytes or bytea…
ed62b49 
…rray of length 1 are expected (pythonGH-117631)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka @erlend-aasland @terryjreedy
X Tutup