gh-117494: extract the Instruction Sequence data structure into a separate file#117496
gh-117494: extract the Instruction Sequence data structure into a separate file#117496iritkatriel merged 9 commits intopython:mainfrom
Conversation
|
Just to confirm, this is a pure refactor with no new functionality? |
markshannon
left a comment
There was a problem hiding this comment.
I don't think the addition of PyObject_HEAD headers is correct, but it looks good otherwise.
|
When you're done making the requested changes, leave the comment: |
Yes. |
Co-authored-by: Mark Shannon <mark@hotpy.org>
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
|
|
Here's the relevant output for the failed test (test.test_dynamic.RebindBuiltinsTests.test_load_global_specialization_failure_keeps_oparg): That's 341 successive (recursive?) calls to |
|
I don't see how this PR could have impacted the recursion depth. |
|
Yeah, it might be something else. I'm looking into it. |
This extracts the instruction sequence data structure to a separate file. Next will be to add the Python interface into this data structure.
Also simplifies
instr_sequence_to_cfgthrough better abstraction.