Remove stray backtick in NEWS entry#115356
Merged
hauntsaninja merged 1 commit intopython:mainfrom Feb 12, 2024
Merged
Conversation
ezio-melotti
added
type-bug
hauntsaninja
approved these changes
Feb 12, 2024
hauntsaninja
added
needs backport to 3.11
|
Thanks @ezio-melotti for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @ezio-melotti for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2024
(cherry picked from commit a82fbc1) Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
|
GH-115363 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2024
(cherry picked from commit a82fbc1) Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
|
GH-115364 is a backport of this pull request to the 3.12 branch. |
hauntsaninja
pushed a commit
that referenced
this pull request
Feb 12, 2024
hauntsaninja
pushed a commit
that referenced
this pull request
Feb 12, 2024
Member
We do: cpython/.pre-commit-config.yaml Lines 26 to 31 in a82fbc1 But this sort of stray backtick isn't detected. If I introduce one like this: -Most exceptions are now ignored when attempting to set the ``__orig_class__``
+Most exceptions are now ignored when attempting to set the ``__orig_class__`It is detected: |
Member
Author
|
If it's not detected maybe we should create an issue about detecting it. |
This was referenced Feb 12, 2024
Member
Author
|
There was an issue already: |
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a stray backtick that I noticed in a NEWS entry, introduced in #115213.
@hugovk, do we run
sphinx-linton NEWS entries?