gh-110190: Fix ctypes structs with array on Windows ARM64#114753
Merged
zooba merged 2 commits intopython:mainfrom Jan 30, 2024
Merged
gh-110190: Fix ctypes structs with array on Windows ARM64#114753zooba merged 2 commits intopython:mainfrom
zooba merged 2 commits intopython:mainfrom
Conversation
Fix the same issue of PR python#112959 on Windows ARM64 platform when using MSVC compiler. MSVC predefined platform preprocessor macro is _M_ARM64.
Contributor
Author
|
@zooba have a look please. I tested it on my Windows ARM64 VM and it works as expected. I should have spotted initially but my experience with Windows is not that extensive (and at the time I didn't have a machine to test on) :) |
Member
|
Ooh, yeah, that seems a likely culprit. I'll build and test on my machine to confirm, but glad it's this simple if it is! |
Member
|
Apologies for the delay, had some infrastructure issues, but the fix looks good. Thanks! |
zooba
added
needs backport to 3.11
|
Thanks @diegorusso for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @diegorusso for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 30, 2024
…onGH-114753) (cherry picked from commit a06b606) Co-authored-by: Diego Russo <diego.russo@arm.com>
|
GH-114774 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 30, 2024
…onGH-114753) (cherry picked from commit a06b606) Co-authored-by: Diego Russo <diego.russo@arm.com>
|
GH-114775 is a backport of this pull request to the 3.12 branch. |
zooba
pushed a commit
that referenced
this pull request
Jan 31, 2024
zooba
pushed a commit
that referenced
this pull request
Jan 31, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
gentoo-bot
pushed a commit
to gentoo/cpython
that referenced
this pull request
Sep 19, 2024
…onGH-114753) (cherry picked from commit a06b606) Co-authored-by: Diego Russo <diego.russo@arm.com> Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot
pushed a commit
to gentoo/cpython
that referenced
this pull request
Sep 19, 2024
…onGH-114753) (cherry picked from commit a06b606) Co-authored-by: Diego Russo <diego.russo@arm.com> Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot
pushed a commit
to gentoo/cpython
that referenced
this pull request
Sep 19, 2024
…onGH-114753) (cherry picked from commit a06b606) Co-authored-by: Diego Russo <diego.russo@arm.com> Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot
pushed a commit
to gentoo/cpython
that referenced
this pull request
Jul 30, 2025
…onGH-114753) (cherry picked from commit a06b606) Co-authored-by: Diego Russo <diego.russo@arm.com> Signed-off-by: Michał Górny <mgorny@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the same issue of PR #112959 on Windows ARM64 platform when using MSVC compiler.
MSVC predefined platform preprocessor macro is _M_ARM64.