gh-114423: Remove DummyThread from threading._active when thread dies#114424
gh-114423: Remove DummyThread from threading._active when thread dies#114424serhiy-storchaka merged 16 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
fabioz
force-pushed
the
release-dummy-thread
branch
from
37699d2 to
5021537
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
fabioz
force-pushed
the
release-dummy-thread
branch
from
6d18536 to
95be658
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
This is not a full review :)
Misc/NEWS.d/next/Library/2024-01-22-11-43-38.gh-issue-114423.6mMoPH.rst
Outdated
Show resolved
Hide resolved
…mMoPH.rst Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: AN Long <aisk@users.noreply.github.com>
Co-authored-by: AN Long <aisk@users.noreply.github.com>
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Clever!
I only have several suggestions for tests.
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM.
Thank you for your contribution @fabioz.
4 participants
PR to remove dummy thread automatically from threading._active.
I guess with this it could start to implement
joinandis_activeproperly, although I'll leave that for future work.Alternatively I guess it could be implemented closer to C and deal with the internal thread state, but this seems to do the work too.