gh-114321: Expose more constants in the fcntl module#114322
Merged
serhiy-storchaka merged 2 commits intopython:mainfrom Jan 22, 2024
Merged
gh-114321: Expose more constants in the fcntl module#114322serhiy-storchaka merged 2 commits intopython:mainfrom
serhiy-storchaka merged 2 commits intopython:mainfrom
Conversation
This was referenced Jan 19, 2024
Member
Author
|
Includes all names from Linux, FreeBSD and NetBSD manpages. OpenBSD does not have new constants, and macOS have too many specific constants to deserve a separate PR. |
ronaldoussoren
approved these changes
Jan 22, 2024
Contributor
ronaldoussoren
left a comment
ronaldoussoren
left a comment
There was a problem hiding this comment.
LGTM
In working on a PR for #113092 I've also tried to add tests that use all added constants, but that primarily resulted in not doing that work because that's a lot of work with few clear advantages. I'll rebase that work on this PR and will skip adding loads of new tests.
Member
Author
|
It is just a first step. Some of these constants is difficult to use without knowing the layout of some structures. I'm going to add helpers to help with this, but this needs more steps. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--114322.org.readthedocs.build/