gh-113878: Add doc parameter to dataclasses.field#114051
Merged
ericvsmith merged 5 commits intopython:mainfrom Sep 27, 2024
Merged
gh-113878: Add doc parameter to dataclasses.field#114051ericvsmith merged 5 commits intopython:mainfrom
doc parameter to dataclasses.field#114051ericvsmith merged 5 commits intopython:mainfrom
Conversation
Member
Author
|
@ericvsmith I resolved conflicts and merged |
ericvsmith
requested changes
Feb 26, 2024
|
When you're done making the requested changes, leave the comment: |
Member
Author
|
I have made the requested changes; please review again |
ericvsmith
requested changes
Mar 18, 2024
Member
Author
|
Thanks, fair comment! I've updated the docs. |
Member
Author
|
I rebased and updated tests. |
ericvsmith
requested changes
Sep 24, 2024
Misc/NEWS.d/next/Library/2024-01-14-11-43-31.gh-issue-113878.dmEIN3.rst
Outdated
Show resolved
Hide resolved
sobolevn
force-pushed
the
issue-113878-2
branch
from
5d0e8ca to
9b300ef
Compare
sobolevn
commented
Sep 25, 2024
ericvsmith
reviewed
Sep 26, 2024
Misc/NEWS.d/next/Library/2024-01-14-11-43-31.gh-issue-113878.dmEIN3.rst
Outdated
Show resolved
Hide resolved
Member
|
I was discussing this at the core sprint, and I think I'd prefer to see |
Member
Author
|
Done! 👍 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--114051.org.readthedocs.build/