GH-113280: Fix ResourceWarning in ssl.SSLSocket connected detection#113282
GH-113280: Fix ResourceWarning in ssl.SSLSocket connected detection#113282graingert wants to merge 3 commits intopython:mainfrom
Conversation
97b76b3 to
9c36721
Compare
3d88a5f to
a9b6d88
Compare
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Can self.close() raise OSError in these cases?
How difficult to write tests?
|
I'm pretty sure self.close() doesn't raise anything, but if it did it would be raised when It's tricky to test as I only managed to reproduce this intermittently |
|
Several lines below an OSError raised by I wonder whether such guard is needed in these cases. |
|
I think |
|
|
Uh oh!
There was an error while loading. Please reload this page.