gh-112510: Add readline.backend for the backend readline uses#112511
gh-112510: Add readline.backend for the backend readline uses#112511encukou merged 7 commits intopython:mainfrom
readline.backend for the backend readline uses#112511Conversation
| # If this fails, the test is skipped because SkipTest will be raised | ||
| readline = import_module('readline') | ||
| if readline.__doc__ and "libedit" in readline.__doc__: | ||
| if readline.backend == "editline": |
There was a problem hiding this comment.
For just internal usage, why not just use readline._backend?
Co-authored-by: Donghee Na <donghee.na92@gmail.com>
|
Thank you! Could you add a test to assert |
Very helpful insight! From my observation, the difference between different versions of the same library is significantly less important than the difference between the two libraries. I can't guarantee that the version of the backend will not ever be used at all in the future, but I would guess that's a very rare case. Both That being said, I think using a single string type for If in the future, |
|
I think we are done with the review for this PR? We should merge this before #107748 so it can use the |
|
One more thing: the docs entry needs a (And I fell into the trap of thinking this is simple enough to use GitHub UI rather than a local clone...) |
|
Thanks for the quick review! |
…pythonGH-112511) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Donghee Na <donghee.na92@gmail.com>
…pythonGH-112511) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Donghee Na <donghee.na92@gmail.com>
readline.backendfor the backendreadlineuses #112510📚 Documentation preview 📚: https://cpython-previews--112511.org.readthedocs.build/