[Enum] update class creation for RuntimeError changes#111815
Merged
ethanfurman merged 2 commits intopython:mainfrom Nov 29, 2023
Merged
[Enum] update class creation for RuntimeError changes#111815ethanfurman merged 2 commits intopython:mainfrom
ethanfurman merged 2 commits intopython:mainfrom
Conversation
prior to 3.12, an error that occurred during class creation, i.e.
enum_class = super().__new__(metacls, cls, bases, classdict, **kwds)
resulted in a RuntimeError being raised with the original exception as
the __cause__.
In 3.12, the original error is propagated with an extra line
Error calling __set_name__ on '_proto_member' instance ...
To discard that noise, the raised exception is recreated before being
raised.
ethanfurman
added
type-bug
|
Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
ethanfurman
added
needs backport to 3.12
|
Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
hugovk
added
needs backport to 3.12
|
Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 29, 2023
(cherry picked from commit f9e6ce0) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
|
GH-112526 is a backport of this pull request to the 3.12 branch. |
ethanfurman
added a commit
that referenced
this pull request
Nov 29, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prior to 3.12, an error that occurred during class creation, i.e.
resulted in a RuntimeError being raised with the original exception as the cause.
In 3.12, the original error is propagated with an extra line
To discard that noise, the raised exception is recreated before being raised.
📚 Documentation preview 📚: https://cpython-previews--111815.org.readthedocs.build/