[3.12] gh-110395: invalidate open kqueues after fork (GH-110517)#111745
Merged
gpshead merged 2 commits intopython:3.12from Nov 11, 2023
Merged
[3.12] gh-110395: invalidate open kqueues after fork (GH-110517)#111745gpshead merged 2 commits intopython:3.12from
gpshead merged 2 commits intopython:3.12from
Conversation
This was referenced Nov 4, 2023
vstinner
reviewed
Nov 6, 2023
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
I didn't review the change in main. I reviewed the change as if it was made in main. Feel free to ignore my review. If you care, issues should be addressed by main first.
this is in `main` via https://github.com/python/cpython/pull/111816/files
vstinner
approved these changes
Nov 7, 2023
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. This time, I reviewed the backport itself, and it LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalidate open select.kqueue instances after fork as the fd will be invalid in the child. (cherry picked from commit a6c1c04)