X Tutup
Skip to content

GH-111435 sharing of bool type in sub interpreters#111436

Merged
ericsnowcurrently merged 7 commits intopython:mainfrom
tonybaloney:serialize_bool
Nov 2, 2023
Merged

GH-111435 sharing of bool type in sub interpreters#111436
ericsnowcurrently merged 7 commits intopython:mainfrom
tonybaloney:serialize_bool

Conversation

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Oct 29, 2023 •
edited
Loading

This PR adds sharing of bool type to the interpreters API

@bedevere-app bedevere-app bot mentioned this pull request Oct 29, 2023
Closed
@corona10
Copy link
Member

corona10 commented Oct 29, 2023 

----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_interpreters.py", line 816, in test_not_shareable
    self.assertFalse(
AssertionError: True is not false

Eclips4
Eclips4 reviewed Oct 29, 2023
View reviewed changes
ericsnowcurrently
ericsnowcurrently reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Oct 31, 2023

Sorry, I moved the registry code to Python/crossinterp.c.

@tonybaloney
Copy link
Contributor Author

tonybaloney commented Oct 31, 2023

Sorry, I moved the registry code to Python/crossinterp.c.

rebased

ericsnowcurrently
ericsnowcurrently approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Oct 31, 2023

I'll merge this once you've had a chance to resolve the merge conflicts from the sharing-float PR.

@tonybaloney
Copy link
Contributor Author

tonybaloney commented Nov 1, 2023

Rebased and conflicts resolved

@ericsnowcurrently ericsnowcurrently enabled auto-merge (squash) November 1, 2023 23:42
@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Nov 1, 2023

Thanks, @tonybaloney!

@ericsnowcurrently ericsnowcurrently merged commit 230e8e9 into python:main Nov 2, 2023
@tonybaloney tonybaloney deleted the serialize_bool branch November 2, 2023 01:18
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@tonybaloney @FullteaR
pythonGH-111435: Add Support for Sharing True and False Between Inter…
7d058ed 
…preters (pythongh-111436)

This only affects users of the APIs in pycore_crossinterp.h (AKA _xxsubinterpretersmodule.c and _xxinterpchannels.c).
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@tonybaloney @aisk
pythonGH-111435: Add Support for Sharing True and False Between Inter…
25a90cb 
…preters (pythongh-111436)

This only affects users of the APIs in pycore_crossinterp.h (AKA _xxsubinterpretersmodule.c and _xxinterpchannels.c).
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@tonybaloney @Glyphack
pythonGH-111435: Add Support for Sharing True and False Between Inter…
548bf79 
…preters (pythongh-111436)

This only affects users of the APIs in pycore_crossinterp.h (AKA _xxsubinterpretersmodule.c and _xxinterpchannels.c).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tonybaloney @corona10 @ericsnowcurrently @Eclips4
X Tutup