X Tutup
Skip to content

gh-111388: Add show_group to traceback.format_exception_only#111390

Merged
iritkatriel merged 3 commits intopython:mainfrom
sobolevn:issue-111388
Oct 27, 2023
Merged

gh-111388: Add show_group to traceback.format_exception_only#111390
iritkatriel merged 3 commits intopython:mainfrom
sobolevn:issue-111388

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 27, 2023 •
edited by github-actions bot
Loading

@sobolevn sobolevn requested a review from iritkatriel as a code owner October 27, 2023 06:58
@bedevere-app bedevere-app bot mentioned this pull request Oct 27, 2023
Closed
iritkatriel
iritkatriel reviewed Oct 27, 2023
View reviewed changes
Lib/traceback.py
for l in formatted
]
else:
yield _format_final_exc_line(stype, self._str)
Copy link
Member

@iritkatriel iritkatriel Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix need to be backported to 3.12/311?

Copy link
Member Author

@sobolevn sobolevn Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because 3.12 does not have show_group / _depth at all:

cpython/Lib/traceback.py

Lines 865 to 892 in 307ca78

def format_exception_only(self):
"""Format the exception part of the traceback.
The return value is a generator of strings, each ending in a newline.
Generator yields the exception message.
For :exc:`SyntaxError` exceptions, it
also yields (before the exception message)
several lines that (when printed)
display detailed information about where the syntax error occurred.
Following the message, generator also yields
all the exception's ``__notes__``.
"""
if self.exc_type is None:
yield _format_final_exc_line(None, self._str)
return
stype = self.exc_type.__qualname__
smod = self.exc_type.__module__
if smod not in ("__main__", "builtins"):
if not isinstance(smod, str):
smod = "<unknown>"
stype = smod + '.' + stype
if not issubclass(self.exc_type, SyntaxError):
yield _format_final_exc_line(stype, self._str)
else:
yield from self._format_syntax_error(stype)

And without it, the result is identical with and without this fix.

@iritkatriel iritkatriel merged commit aa73245 into python:main Oct 27, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-111388: Add show_group parameter to `traceback.format_exce…
fe9610e 
…ption_only` (python#111390)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-111388: Add show_group parameter to `traceback.format_exce…
eb16762 
…ption_only` (python#111390)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn @iritkatriel
X Tutup